-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optionally ack writes to kafka on Push requests #14186
Merged
benclive
merged 8 commits into
main
from
benclive/optionally-make-kafka-writes-required
Sep 23, 2024
Merged
feat: Optionally ack writes to kafka on Push requests #14186
benclive
merged 8 commits into
main
from
benclive/optionally-make-kafka-writes-required
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Sep 20, 2024
github-actions
bot
added
the
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
label
Sep 20, 2024
cyriltovena
reviewed
Sep 23, 2024
pkg/distributor/distributor.go
Outdated
return nil, fmt.Errorf("failed to start kafka client: %w", err) | ||
} | ||
kafkaWriter = kafka.NewProducer(kafkaClient, cfg.KafkaConfig.ProducerMaxBufferedBytes, | ||
prometheus.WrapRegistererWithPrefix("_kafka_ingester_", registerer)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: may be kafka_distributor or just kafka ?
cyriltovena
reviewed
Sep 23, 2024
cyriltovena
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the ability for the distributor to send requests to multiple places (like the Tee) but also ensuring that all of those requests are successful via tracking their responses.
I'm not particularly sold on the re-use of the Tee model and re-using the tracker object like I have. I'm definitely open to suggestions on alternatives!
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/loki-private/issues/1109
Special notes for your reviewer:
I'm wondering whether to continue with this approach and convert the existing implementation to it's own Tee so we can manage them in the same way, or if that is overkill.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.